Skip to content

Expect same controler GUID format for SDL2 on Windows as Linux#18635

Merged
sonninnos merged 1 commit intolibretro:masterfrom
bcat:sdl2
Jan 23, 2026
Merged

Expect same controler GUID format for SDL2 on Windows as Linux#18635
sonninnos merged 1 commit intolibretro:masterfrom
bcat:sdl2

Conversation

@bcat
Copy link
Copy Markdown
Contributor

@bcat bcat commented Jan 22, 2026

Description

RA parses the SDL joystick GUID differently for Windows than it does for Linux. However, SDL has used the same GUID format on all platforms for quite some time (since 2.0.5, and RA's currently bundling 2.0.14.0 with its Windows builds).

Since we currently parse the GUID wrong on Windows, without this change, using the SDL2 driver on Windows results in bogus input_vendor_id and input_product_id values:

wrong-vid-pid

After this change, the values are correct:

right-vid-pid

(Notice the fixed sdl2 driver values now match the correct ones reported by the xinput driver.)

Related Issues

Fixes #18634.

Related Pull Requests

[Any other PRs from related repositories that might be needed for this pull request to work]

@cmitu
Copy link
Copy Markdown
Contributor

cmitu commented Jan 22, 2026

I think this PR includes - by mistake probably - your own retroarch.cfg, which overwrites the example commented retroarch.cfg present in the repository.

@sonninnos
Copy link
Copy Markdown
Collaborator

sonninnos commented Jan 22, 2026

It sure does. Never run RA from the build dir.

@bcat
Copy link
Copy Markdown
Contributor Author

bcat commented Jan 22, 2026

D'oh. You're right of course. That's why I shouldn't send PRs late at night....

Will fix this evening, apologies.

@sonninnos
Copy link
Copy Markdown
Collaborator

sonninnos commented Jan 22, 2026 •
edited
Loading

I renamed the skeleton default cfg to avoid similar confusion in the future. Still weird how it got included in since retroarch.cfg is in .gitignore..

Edit: Sigh, had to revert the rename because packaging scripts fail otherwise.

@bcat
Copy link
Copy Markdown
Contributor Author

bcat commented Jan 23, 2026 •
edited
Loading

Removed the retroarch.cfg that snuck in.

Also tested a bit more locally with various different controllers (XInput, DInput, Switch controllers, wired & wireless, etc.), and this seems to have the desired effect for them all.

Side note: Other than this small bug, I'm quite happy with the SDL controller experience overall. The usual XInput and DInput devices work the same as before, and some controllers that reported identical input_device values (8BitDo Ultimate 2 vs Pro 3) in the xinput driver have distinct ones with the sdl2 driver. But the main QoL improvement is that Switch controllers (Pro Controller, N64 controller, etc.) work without issue. (I did drop in a newer SDL DLL since the RetroArch one is a bit old, and there've been some Switch-related fixes upstream since then.)

@sonninnos sonninnos merged commit e0fe988 into libretro:master Jan 23, 2026
34 checks passed
@gouchi gouchi mentioned this pull request Jan 23, 2026
Open
@bcat bcat deleted the sdl2 branch January 23, 2026 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

sdl2 controller driver reports USB VID/PID incorrectly on Windows due to outdated GUID parsing

3 participants

@bcat @cmitu @sonninnos